Extract Source trait for flush-thread data sources#408
Merged
Conversation
Introduce a `Source` trait that abstracts "thing the flush thread drains into the central collector." CpuProfiler and SchedProfiler now implement Source, and the recorder holds them as `Vec<Box<dyn Source>>` in SharedState instead of separate typed fields. This is a pure refactor with no behavior change: - The flush loop iterates sources and calls source.flush(&ctx) - Worker thread start/stop hooks iterate sources for on_worker_thread_start/stop - The trait is pub(crate) and gated behind cfg(feature = "cpu-profiling") Future data sources (e.g. memory profiler) can implement Source without touching the recorder wiring.
ThreadRole is used by the Source trait infrastructure which compiles unconditionally. Remove the cpu-profiling feature gate so the enum is always available.
yulnr
approved these changes
May 18, 2026
Collaborator
There was a problem hiding this comment.
Great idea!
nit: this is adding some dead-code warnings (Source trait, FlushContext + fields, methods) when building without cpu-profiling (the trait has no impls without cpu profiling). Can we suppress those somehow? e.g. #[cfg_attr(not(feature="cpu-profiling"), allow(dead_code))] (for now)?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce a
Sourcetrait that abstracts "thing the flush thread drains into the central collector." CpuProfiler and SchedProfiler now implement Source, and the recorder holds them asVec<Box<dyn Source>>in SharedState instead of separate typed fields.This is a pure refactor with no behavior change:
Future data sources (e.g. memory profiler) can implement Source without touching the recorder wiring.